HDDS-2201. Rename VolumeList to UserVolumeInfo.#1566
Merged
anuengineer merged 2 commits intoapache:trunkfrom Oct 2, 2019
Merged
HDDS-2201. Rename VolumeList to UserVolumeInfo.#1566anuengineer merged 2 commits intoapache:trunkfrom
anuengineer merged 2 commits intoapache:trunkfrom
Conversation
| @@ -27,22 +28,22 @@ | |||
| /** | |||
| * Codec to encode VolumeList as byte array. | |||
Contributor
There was a problem hiding this comment.
Javadoc needs to be updated
Contributor
Author
There was a problem hiding this comment.
Thank you for catching this, fixed.
| @@ -53,7 +53,7 @@ public OMVolumeRequest(OMRequest omRequest) { | |||
| * @return VolumeList - updated volume list for the user. | |||
Contributor
There was a problem hiding this comment.
Javadoc needs to be updated.
Contributor
Author
There was a problem hiding this comment.
Thank you for catching this, fixed.
| /** | ||
| * Tests for OM Response. | ||
| */ | ||
| package org.apache.hadoop.ozone.om.response; No newline at end of file |
Contributor
There was a problem hiding this comment.
New line missing at end of file.
Contributor
Author
There was a problem hiding this comment.
Thank you for catching this, fixed.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.ozone.om.response.volume; No newline at end of file |
Contributor
There was a problem hiding this comment.
Missing javadoc and new line at EOF.
Contributor
Author
There was a problem hiding this comment.
Thank you for catching this, fixed.
dineshchitlangia
requested changes
Oct 1, 2019
Contributor
There was a problem hiding this comment.
Thanks @anuengineer for working on this.
Overall looks good, some minor comments inline regarding javadocs.
Pending CI.
|
💔 -1 overall
This message was automatically generated. |
dineshchitlangia
approved these changes
Oct 1, 2019
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 Pending CI, thanks @anuengineer !
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Test failures are not related to this patch. Committed to trunk. @dineshchitlangia Thank you for the review. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-2201
Under Ozone Manager, The volume points to a structure called volumeInfo, Bucket points to BucketInfo, Key points to KeyInfo. However, User points to VolumeList. duh?
This JIRA proposes to refactor the VolumeList as UserVolumeInfo. Why not, UserInfo, because that structure is already taken by the security work of Ozone Manager.
How tested: Ran unit.sh